alteryx/featuretools

Add tests that confirm primitive input_types are the expected shapes

Open

#2,086 创建于 2022年5月19日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)Python (6,895 star) (853 fork)batch import
good first issue

描述

There are a number of assumptions we make about the shape of Primitive input_types lists:

  • Its either a list of ColumnSchema objects or a list of lists of ColumnSchema objects (and not a combination)
  • All sub-lists are the same length
  • No input_types list or sublist is empty

As we may need to rely on these assumptions at some point, we should add tests that confirm these assumptions for all primitives, so that if we add a Primitive that breaks any of these assumptions in the future, we are notified.

贡献者指南

技术栈
python
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonpytestFeaturetools Primitive API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Locate the test files for primitives in the repository (likely under featuretools/tests/primitive tests/). Create a new test function that iterates over all registered primitives and validates the assumptions listed in the issue: that input types is either a list of ColumnSchema or a list of lists of ColumnSchema, that all sub lists have equal length, and that no list or sublist is empty. Use pytest to assert these conditions for each primitive. Ensure to import the necessary modules and check the PrimitiveBase class.
Add tests that confirm primitive input_types are the expected shapes · alteryx/featuretools#2086 | Good First Issue