alibaba/GraphScope

[BUG] g.graphlearn()/g.gremlin() should check if the type is compatible first

Open

#1,509 创建于 2022年5月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)HTML (2,401 star) (301 fork)batch import
component:pythonenhancementgood first issue

描述

Describe the bug

GraphLearn has implies int64_t as OID_T (see types.h) and current gremlin engine doesn't support string oids as well (see https://github.com/alibaba/GraphScope/issues/1265).

An exceptions should be thrown in g.graphlearn()/g.gremlin() is the oid type of vineyard graph is not compatible with those two engines.

贡献者指南

技术栈
cpp
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic C++understand OID typesfamiliarity with GraphScope codebase
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Investigate the g.graphlearn() and g.gremlin() functions in the GraphScope codebase to identify where to add the type compatibility check. Refer to the types.h file (graphlearn/core/graph/storage/types.h) which defines OID T as int64 t. The exception should be thrown when the vineyard graph's OID type is not compatible. Also consider checking the linked issue #1265 for context on gremlin engine limitations. The fix should be localized and throw an appropriate error message.