alexa-pi/AlexaPi

Reusing the config file on install skips authorization

Open

#186 创建于 2017年3月4日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (1,324 star) (402 fork)batch import
bugenhancementhelp wantedrequest

描述

Your OS (including version) where you are running AlexaPi:

OSMC (Debian 8.7)

Your hardware platform and model you are running on:

Raspberry PI 2

Python release (python2 --version):

Python 2.7.9

Description of problem:

If you already have a config file the installer will ask if you want to Keep, Edit or Delete, choosing Keep it does exit the installer even if there is no token saved in the config file. You need to run manually python auth_web.py to finish the configuration.

Expected:

Check if there is a token and is not expired and only then skip the authorization part.

Problem-relevant config.yaml entries:

Steps to reproduce:

  1. Install AlexaPi and kill or get an error after config is created but before authorization is saved
  2. Try to install again

Traceback (if applicable):

Additional info:

贡献者指南

技术栈
python
领域
backendcli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Python basicsconfig file handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue is about the installer skipping authorization when a config file exists but lacks a valid token. The fix involves checking the token validity before skipping the authorization step. Relevant files likely include the install script and auth web.py. The single comment may provide additional context. The expected behavior is to verify token and only skip if valid.