alanshaw/david

Outdated status should respect supported node versions

Open

#95 创建于 2015年12月28日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)JavaScript (962 star) (81 fork)batch import
help wanted

描述

Here is an example explaining the issue.

  • foo supports node version >= 0.10.0
  • foo depends on version 1.x.x of bar
  • bar version 2.0.0 is published and supports node version => 4.0.0
  • bar version 1.0.0 supports node version >= 0.10.0

David shouldn't show an outdated badge for foo, since foo is using the latest supported version of bar on the version of node that foo runs on.

Either that, or David should have an updated status for this special case.

贡献者指南

技术栈
javascriptnodejs
领域
toolingdeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of npm semverreading David's source code
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate how David currently determines outdated status by examining the main logic in index.js. Understand how it queries npm registry and compares versions. The fix requires incorporating the node engine requirements from the package.json ( both the parent and child packages ) to avoid marking a dependency as outdated when the parent's node version cannot support the newer version. Look for functions that handle version comparisons and check the engines field in the package data.