alanshaw/david-www

Badge colour always green when all dependencies pinned

Open

#48 创建于 2013年7月16日

在 GitHub 查看
 (2 评论) (2 反应) (0 负责人)JavaScript (733 star) (177 fork)batch import
bughelp wantedquestion

描述

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned all dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will always be green.

I propose that when all dependencies are pinned, absolute versions should affect the David badge colour.

贡献者指南