akxcv/vuera

Distribution file compatibility

Open

#29 创建于 2018年2月22日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (4,260 star) (264 fork)batch import
good first issuehelp wanted

描述

This issue came up because of IE11, but I totally understand if including support for IE11 is not something within the scope of this library. It looks like es2015 compatibility is desired based on the .babelrc:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/.babelrc#L6

However, both Object.assign and Object.entries appear in the built common js file:

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L229

https://github.com/akxcv/vuera/blob/30ab626d8105ed8b2223ca2aa45495daa112529a/dist/vuera.cjs.js#L451

I always forget which level Object.assigns is at, but I believe Object.entries is much more recent? Is this maybe a bug in the rollup or babel configuration during the build?

Thanks!

贡献者指南

技术栈
javascriptreactvue
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of ES5/ES6 featuresfamiliarity with Babel configuration
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate the .babelrc file at line 6 to see the target environment configuration. Check the rollup config to understand how the dist files are built. Determine if Object.assign and Object.entries need to be polyfilled or if the build targets should be adjusted to avoid these modern methods.