akveo/ngx-admin

AnalyticsService check that ga function exists

Open

#5,523 创建于 2019年10月2日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (24,990 star) (7,916 fork)batch import
P4: nice to havebughelp wantedneeds triage

描述

Issue type

I'm submitting a ... (check one with "x")

  • [ X] bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:

error in console while ad-blocker is active

Expected behavior:

No error (or maybe a log that tells that GA is not available Steps to reproduce:

  1. Enable analytics
  2. Run when ad-blocker is on

Related code:

insert short code snippets here

Other information:

npm, node, OS, Browser

<!--
Node, npm: `node --version` and `npm --version`
OS: Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra?)
Browser: Chrome/Safari/Firefox/etc?
-->

Angular, Nebular

<!--
Check your `package-lock.json` or locate a `package.json` in the `node_modules` folder.
-->

贡献者指南

技术栈
angulartypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of TypeScriptFamiliarity with Angular services
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue is to add a null check for the global `ga` function in the AnalyticsService to prevent console errors when an ad blocker is active. Look in `src/app/@core/utils/analytics.service.ts` for where `ga` is called. Add an if statement to check if `typeof ga !== 'undefined'` before invoking it. Also consider adding a console.warn when GA is not available. The issue has 2 comments which may provide additional context; review them for any suggested approach. No linked PRs.