aksonov/react-native-router-flux

Actions.pop always return true

Open

#3,337 创建于 2018年10月30日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (8,999 star) (2,112 fork)batch import
bughelp wanted

描述

Version

Tell us which versions you are using:

  • react-native-router-flux v4.0.4
  • react v16.2.0
  • react-native v0.53.3

Expected behaviour

In RNRF v4.0.0-bate25, Actions.pop return false if the sence is the first page, but 4.0.4 always return true.How do I tell if my stack is currently empty?

Actual behaviour

As above

贡献者指南

技术栈
javascriptreact nativereact
领域
mobile
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of React Native navigationFamiliarity with react native router flux APIBasic JavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Actions.pop implementation in the library's source code, likely in the core router file. The pop method should check if there is only one scene in the stack and return false in that case. Look for any recent changes that might have removed this check. Test with a minimal React Native app using the library and verify that Actions.pop returns false when navigation stack has only one scene.