akka/akka-http

empty Uri fragment ignored

Open

#3,859 创建于 2021年6月29日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)Scala (1,311 star) (598 fork)batch import
1 - triagedhelp wantedt:coret:model

描述

The Uri.withFragment function does not allow one to set an empty fragment, which is allowed by the IETF spec I believe, and by the Uri constructor, as shown:

import akka.http.scaladsl.model.Uri
import Uri.*

scala> val good = Uri("https",Authority(Host("example.com")),Path./("doc"),None,Some(""))       
val good: akka.http.scaladsl.model.Uri = https://example.com/doc#

scala> val noFrag = Uri("https",Authority(Host("example.com")),Path./("doc"),None,None)
val noFrag: akka.http.scaladsl.model.Uri = https://example.com/doc

scala> noFrag.withFragment("")
val res3: akka.http.scaladsl.model.Uri = https://example.com/doc

贡献者指南

技术栈
无
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Scala basicsURI RFC knowledgeAkka HTTP source structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue is in the `withFragment` method of `Uri` class in Akka HTTP. The current implementation treats an empty string as no fragment, but the URI constructor allows empty fragment. To fix, examine `Uri.scala` around the `withFragment` method (likely in `akka http core/src/main/scala/akka/http/scaladsl/model/Uri.scala`). The fix should ensure that setting an empty fragment string results in a URI with an empty fragment, not `None`. Check the constructor logic for how fragment is stored and adapt `withFragment` accordingly. Also review the IETF URI spec (RFC 3986) to confirm empty fragment is allowed.
empty Uri fragment ignored · akka/akka-http#3859 | Good First Issue