akka/akka-http

Improved handle APIs for websockets that automatically accumulate messages etc

开放

#1,979 创建于 2018年4月6日

 (3 条评论) (0 个反应) (0 位负责人)Scala (598 个派生)batch import
1 - triagedhelp wanted

仓库指标

星标
 (1,311 个星标)
PR 合并指标
 (平均合并 1天 10小时) (30 天内合并 2 个 PR)

描述

This is a good idea by @jrudolph to improve handling websockets:

https://github.com/akka/akka-http/pull/611#issuecomment-275113296


I think the change does what it advertises. However, I'd like to experiment with alternative APIs, instead, before people start to use toStrict (which requires to deal with futures) when an alternative could solve the issue in a simpler way.

What I'd like to try first is adding a method to UpgradeToWebSocket:

def handleStrictMessages(Graph[FlowShape[StrictMessage, Message], Any], ...)
def handleStrictTextMessages(Graph[FlowShape[TextMessage.Strict, Message], Any], ...)
def handleStrictBinaryMessages(Graph[FlowShape[BinaryMessage.Strict, Message], Any], ...)

where StrictMessage is either a new hierarchy of WS messages or a new subtype. All of these should automatically "do the right thing", i.e. accumulating streamed messages with a configured timeout and maximum size and ignore messages of the wrong shape. We could probably reuse your toStrict logic for it. Is that something you would like to help with, @rbudzko?

贡献者指南