akka/akka-core

Serialization issues with Option

开放

#29,923 创建于 2020年12月30日

 (3 条评论) (0 个反应) (0 位负责人)Scala (3,547 个派生)batch import
1 - triagedhelp wanted

仓库指标

星标
 (13,277 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Some example projects and also the current style guide recommend using Option for state in event sourced behaviors (entities). This causes two issues:

  1. Double serialization - Option is caught by MiscMessageSerializer, which delegates payload serialization to another serializer based on configuration and then serializes the result again with ContainerFormats.Option.
  2. Payload serialization is always synchronous, so this results in blocking IO in a case where state uses AsyncSerializer.

These issues could be fixed by implementing following changes:

  1. Altering documentation to suggest using sealed trait hierarchies or case classes which contain Option to express empty state.
  2. Converting MiscMessageSerializer to AsyncSerializer.

Behavior seems obviously undesirable, so I'm wondering if I am missing something or does this actually need fixing?

I've noticed this issue with Lagom 1.6.4 entities, but since they fallback to Akka actors for everything I assume this is a general Akka issue.

贡献者指南