akka/akka-core

MetricsCollector.apply() does not report exceptions from custom collector creation

开放

#27,673 创建于 2019年9月10日

 (1 条评论) (0 个反应) (0 位负责人)Scala (3,547 个派生)batch import
1 - triagedhelp wanted

仓库指标

星标
 (13,277 个星标)
PR 合并指标
 (平均合并 8天 19小时) (30 天内合并 10 个 PR)

描述

When custom collector class is specified and fallback collector is allowed, MetricsCollector.apply() attempts to instantiate it in a TryNative. If it fails, it simply instatiates the fallback collector without reporting the problem. It should log the exception with stack trace.

We've discovered by accident that some of our non-critical metrics were not collected because of this --- without any indication in the logs.

贡献者指南