akiran/react-slick

slick-cloned slides visible if slidesToDisplay > slide count

Open

#1,569 创建于 2019年6月11日

在 GitHub 查看
 (4 评论) (2 反应) (0 负责人)JavaScript (11,386 star) (2,109 fork)batch import
good first issue

描述

In recent versions, if slidesToShow is set to a value greater than the number of slides, all of the slick-cloned slides will be visible.

To replicate: in the PlayGround (https://codesandbox.io/s/ppwkk5l6xx) update the settings:

var settings = {
      dots: true,
      slidesToShow: 5
    };

Version 0.21.0 does not behave this way. With version 0.21.0 if the slidesToShow is greater than the number of slides, it does not create the slick-cloned slides.

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic ReactUnderstanding of react slick
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the logic that generates slick cloned slides in react slick, specifically in the component that handles slidesToShow. Compare current behavior with version 0.21.0 where the clones were not created when slidesToShow exceeds slide count. The relevant code is likely in the initialization or rendering of slides. Check for a condition that should prevent cloning when slide count is less than slidesToShow.