ajaxorg/ace

Add support for numeric separator in Javascript and PHP

Open

#5,256 创建于 2023年7月15日

在 GitHub 查看
 (5 评论) (1 反应) (0 负责人)JavaScript (26,357 star) (5,252 fork)batch import
effort/smallfeature-requestgood first issuemode-requestp2

描述

Describe the feature

Please add a validation for the numeric number separator in Javascript: image

Use Case

https://github.com/tc39/proposal-numeric-separator

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

1.23.4

贡献者指南

技术栈
javascriptphp
领域
frontenddeveloper experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScript syntaxPHP syntaxAce editor mode structure
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
This is a feature request to add validation for numeric separators (e.g., 1 000 000) in JavaScript and PHP within Ace. To implement, examine how numeric literals are currently tokenized in the JavaScript and PHP syntax mode files (likely under lib/ace/mode/). Using the TC39 proposal as reference, modify the regular expressions or tokenizer rules to allow underscores in numbers. Look at existing PRs or comments for guidance; one comment suggested using the 'go' mode as a reference. Coordinate with maintainers to ensure consistency with Ace's overall approach.