ajaxorg/ace

XML Syntax Error Indication on a Wrong Line

Open

#3,479 创建于 2017年12月11日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (26,357 star) (5,252 fork)batch import
bugeffort/smallgood first issuep2

描述

Tested Browsers / Devices

Windows 10

  • FAIL:
    • Chrome 63.0.3239.84
    • Edge 41.16299.15.0
    • IE 11
    • Firefox 57.0.1
  • OK: n/a

URL Minimal Example

https://ace.c9.io/build/kitchen-sink.html?doc=XML

Steps to Reproduce the Problem

  1. Open an XML document to edit
  2. Optional: If it's not already the case, separate a single-lined XML tag into multiple LOC
  3. Add a syntax error intentionally e.g. a character right after an attribute value: "..."s.

What Is the Expected Result?

ace editor xml expected error indication placement The error / warning indication is on the same line as where the error actually placed.

What Happens Instead?

ace editor xml wrong error indication placement

Any other information?

Even with an XML tag which has all the attributes in a single line, the indication is placed somewhere else which is weird. ace editor xml wrong error indication placement even with a single line I had a case where I made such a syntax error and didn't know where it was until I had to scroll down.

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of Ace editorFamiliarity with JavaScriptUnderstanding of XML syntax error handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
Investigate the XML mode in Ace, specifically the file lib/ace/mode/xml highlight rules.js and how error markers are computed. Check the tokenization process and see why the error indicator is placed on a wrong line when a syntax error occurs after an attribute value. Review existing comments on the issue for hints. The bug appears to be in the error positioning logic that does not account for line breaks in multi line tags.