airbnb/rheostat

Aria-labels can't be added to slider buttons

Open

#273 创建于 2020年1月3日

在 GitHub 查看
 (3 评论) (9 反应) (0 负责人)JavaScript (1,688 star) (215 fork)batch import
enhancementhelp wanted

描述

For compliance, I need to add aria-labels to the slider buttons in an implementation like this one: http://localhost:9001/?path=/story/slider--rtl-multiple-handle. There doesn't seem to be a way to do this currently.

贡献者指南

技术栈
javascriptreact
领域
frontendaccessibility
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic React knowledgeunderstanding of ARIA attributes
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The issue is to add aria labels to slider buttons in the rheostat component. Start by examining the slider component source code in the repository to identify where buttons are rendered. Look for existing prop handling for accessibility attributes. Check comments on the issue for any suggested approach. Consider adding a prop like `buttonAriaLabel` that can be passed to each handle. Ensure to update the component's TypeScript definitions if present. Test the change using the existing test suite and manual verification.
Aria-labels can't be added to slider buttons · airbnb/rheostat#273 | Good First Issue