airbnb/native-navigation

Provide an installation option without CocoaPods

开放

#54 创建于 2017年3月20日

 (9 条评论) (4 个反应) (0 位负责人)Java (172 个派生)github user discovery
help wantediOS

仓库指标

星标
 (3,120 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Dear authors,

Currently, there is only one way how you can add this project to iOS app (using CocoaPods). As a JavaScript / React Native developer, I'd like to be able to install this awesome library using react-native install or link it by using react-native link. Although it's not hard to do, the code won't work with a standard react-native init app due to the current way it imports React (using import React in Swift files).

I managed to make it work without these imports (by adding native-navigation library directly to the project), but I consider this way pretty hackish as I have to remove these imports by hand. I'd like to find a way how we can distribute a Cocoa pod using CocoaPods and npm module using the same codebase. The best thing I can think of is a pre-publish hook that cuts off imports before publishing (tmp dir -> s/import React//g -> publish files from tmp dir -> rm tmp dir).

What do you think?

贡献者指南