airbnb/epoxy

Use default value from kotlin setter in a model view

Open

#598 创建于 2018年10月30日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Java (8,412 star) (738 fork)batch import
help wanted

描述

In @ModelView components setting default values is a pain, since the annotation @ModelProp has to take a string reference by name of a constant.

With kotlin's native support of default values, ideally the generated epoxy model could call a no-arg version of the setter to have the default value used.

The annotation processor and generated code would have to be updated for this. Main issues I see are having the annotation processor know if a default value is present (I think there is a kotlin metadata library we can use for that), and since the generated model is in java it needs to be able to access the no arg version of the function, so many jvmoverloads is required, but it would be nice to not need that

贡献者指南

技术栈
kotlinjavaandroid
领域
mobile
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Experience with Epoxy libraryUnderstanding of annotation processingKotlin language basicsFamiliarity with JVM overloads
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Investigate the Epoxy annotation processor codebase, specifically the handling of @ModelProp. Use the Kotlin metadata library to detect default values. Consider implementing a no arg setter call in the generated Java model class. Check if JvmOverloads annotation is required and how it interacts with the generated code. Look at existing issues or PRs related to Kotlin default values for guidance.