addyosmani/timing.js

ie8 doesn't safely fail

Open

#6 创建于 2014年9月25日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (1,504 star) (123 fork)batch import
enhancementhelp wanted

描述

Want to encorporate this in our product behind a flag, however if the browser is ie8 (argh), ideally it just needs to fail silently without throwing a script error. Can we prevent the error for ie8?

Script throws an error

"'timing is null or not an object"

贡献者指南

技术栈
javascript
领域
frontendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic JavaScriptUnderstanding of browser detectionFamiliarity with Navigation Timing API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Investigate the code in timing.js, likely the main script, to identify where performance.timing is accessed. Add a check for the existence of performance and performance.timing before using it, or wrap in a try catch to prevent the error in IE8. Ensure that in unsupported browsers, the library fails silently without throwing exceptions.