addyosmani/critical

Remove query string from stylesheet path

Open

#551 创建于 2023年1月31日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (9,902 star) (457 fork)batch import
bughelp wanted

描述

In my simple PHP file I reference my stylesheet as follows:

<link rel="stylesheet" href="css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>"

When using the CLI, I get the following error:

Error: File not found: css/style.css?v=<?php echo filemtime( 'css/style.css' ); ?>

This could be addressed by automatically removing query strings like ?v before trying to access the file. After that it works as expected.

贡献者指南

技术栈
javascript
领域
frontendperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptunderstanding of file paths
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Investigate how the tool resolves file paths in the CLI. The issue suggests removing query strings (e.g., `?v=...`) from the href before accessing the file. Check the source code for where `css/style.css?v=...` is passed; likely in `lib/` or `src/`. Look for `path` or `fs` operations. The fix would involve stripping the query string using `url.parse` or string split. No linked PRs or comments.