actualbudget/actual

[Bug]: Filtered balance on Split's notes not calculating properly

Open

#4,381 创建于 2025年2月14日

在 GitHub 查看
 (2 评论) (1 反应) (0 负责人)JavaScript (7,129 star) (603 fork)batch import
bughelp wantedtransactions

描述

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

When trying to filter transactions by Note, the "Filtered Balance" doesn't include the split if each line doesn't also have the note.

I would expect that the split be included if each split note is empty. If each split has a different note, then those splits should be filtered accordingly. For example, in the image, if the note on the External Purchases split said "Family" I would not expect it to calculate in the "contains kro" filter. However, those splits that are empty should calculate. Otherwise, every split needs to have all fields filed out to calculate properly.

Image

How can we reproduce the issue?

How can we reproduce the issue? Create a split transaction, notate the main split, but not the individual sub-splits, filter by note. Filtered Balance will be different than expected, and not show non-notated sub-splits.

Where are you hosting Actual?

Locally via Yarn

What browsers are you seeing the problem on?

Chrome, Firefox

Operating System

Windows 11

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of split transactions in ActualFamiliarity with note filtering logic
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the filtering logic for split transactions in the Actual codebase. Focus on how the 'Filtered Balance' is computed when a note filter is applied. Check the transaction list component and the account calculation functions. The bug suggests that sub splits without notes are not being considered when the parent transaction's note matches the filter. Expected behavior is that empty notes should be inherited from the parent. Look at files related to transaction filtering and balance calculation, such as in the loot core or desktop client packages. Review any existing tests for split transaction filtering.