abetlen/llama-cpp-python

suppress_stdout_stderr failing in notebooks

已关闭

#872 创建于 2023年11月5日

在 GitHub 查看贡献者指南
 (3 条评论) (0 个反应) (0 位负责人)Python (1,441 个派生)batch import
bughelp wanted

仓库指标

星标
 (10,558 个星标)
PR 合并指标
 (平均合并 1天 5小时) (30 天内合并 68 个 PR)

描述

Expected Behavior

Loading a model with verbose=False should not print things.

Current Behavior

verbose=False has no effect in notebooks (I tested with VS Code notebooks, but I think it is ipykernel related)

Steps to Reproduce

Just load a model with verbose=False and observe output in a notebook environment.

How to fix

The patch given in the ipykernel issue below fixes the issue for me (but requires me to do my own override of stdout and stderr since the patch also causes suppress_stdout_stderr to crash as currently written). A real fix might involve integrating this into suppress_stdout_stderr directly.

https://github.com/ipython/ipykernel/issues/795

thanks!

贡献者指南

研究方向
The issue is about `suppress stdout stderr` not working in notebook environments. The fix likely involves modifying the `suppress stdout stderr` function in the codebase, referencing the ipykernel issue (https://github.com/ipython/ipykernel/issues/795) for a patch. The function may live in a utility module; check the repository's source tree for relevant files. Integrate the patch to handle stdout/stderr redirection properly for ipykernel.
技术栈
python
领域
backend
议题类型
缺陷
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 小时
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
新近可参与
清晰度议题是否清楚说明期望改动、验收标准和下一步。
基本清晰
前置要求
understanding of Python's io modulebasic knowledge of ipykernel
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60