Zannick/logic-graph

Allow setting a max price for movements

开放

#165 创建于 2024年5月22日

 (0 条评论) (0 个反应) (0 位负责人)Rust (0 个派生)auto 404
good first issue

仓库指标

星标
 (4 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Essentially, we want a way to deal with exit movements that have prices with them, and to ignore/drop the exit if its price is larger than the maximum possible. It should be better to not have the exit at all in the graph if it can never be used, but also it doesn't seem great to add the exit, generate the code, check the price, and replace the exit in the yaml with a comment about how it's impossible. So some sort of compromise might be helpful.

Emitting a warning for exceeding the max price and not creating an exit will be useful if the goal is to keep such exits from being defined. This is probably better than silently dropping the exit alone, especially if there are any errors in the exit definition. If we left in the exit, then any error that resulting in the exit being impossible to use can only be tracked down with unittests to explain it, which requires a cargo build and unittests on top of the codegen.

贡献者指南