WordPress/gutenberg

NumberControl: Disable dragging on touch devices

Open

#38,865 创建于 2022年2月16日

在 GitHub 查看
 (2 评论) (3 反应) (0 负责人)JavaScript (9,607 star) (3,893 fork)batch import
Good First Issue[Package] Components[Status] In Progress[Type] Bug

描述

The drag-to-change-value gesture will not work nicely on touch devices unless we disable browser scrolling with touch-action: none.

There is a separate question of whether we really want this dragging gesture on touch devices, because there is no cursor affordance like on desktop. It’s also pretty easy to accidentally flick and change the value, when you just want to tap/move the caret or something.

I’m inclined to disable the drag gesture on touch devices.

Tested on iPhone (Mobile mode in DevTools has different behavior)

贡献者指南

技术栈
javascriptreactcss
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Knowledge of React componentsCSS touch action propertyUnderstanding of touch events
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Look into the NumberControl component in the Gutenberg repository, likely in packages/components/src/number control/. The issue suggests adding `touch action: none` to disable browser scrolling during drag, and potentially conditionally disabling the drag gesture on touch devices. Check the existing event handlers and CSS for the component. The issue mentions using `use gesture` library, so examine how the drag event is set up. A maintainer may have additional input in the comments.