W4RH4WK/Debloat-Windows-10

Recommendation: Move the DNS/IPs out of hardcoded variables and into their own separate text files

Open

#301 创建于 2022年5月18日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)PowerShell (6,158 star) (804 fork)batch import
help wanted

描述

I'm not sure if this repo is maintained anymore, but just from a QoL/best practice perspective, I found it interesting that the server names and IPs were hardcoded into the PowerShell scripts. This makes it difficult to read the raw data if one wanted to say, import the list into Pi-Hole and block the servers from the network. From a maintenance perspective, it also separates the script's functional portions from the ephemeral data (i.e., the ever-changing servers/IPs).

Could it be possible to move the server names/IPs specified in the debloat ps1 files to their own separate and sanitized text files?

贡献者指南

技术栈
无
领域
tooling
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PowerShell
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Review all .ps1 files in the repository to locate hardcoded IP addresses or server names. Create separate text files (e.g., blocked servers.txt) for each set of values, and modify the PowerShell scripts to read from these files. Ensure backward compatibility and test the scripts after the change. Consider adding a comment or documentation explaining the new file format.