Vincit/objection.js

Missing typings for QueryBuilder.tableRef

Open

#2,364 创建于 2023年3月16日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (663 fork)batch import
good first issuetypings

仓库指标

Star
 (7,146 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

QueryBuilder has a convenient method tableRef which returns the alias for the model the query builder operates against:

https://github.com/Vincit/objection.js/blob/1b74f756c8afd3bab7964ac3aea7438b95edce44/lib/queryBuilder/QueryBuilder.js#L87-L89

However it's not exposed in typings and not mentioned in the documentation. Can we add it?


On a side note, its implementation clearly contradicts the typings for tableRefFor:

https://github.com/Vincit/objection.js/blob/1b74f756c8afd3bab7964ac3aea7438b95edce44/typings/objection/index.d.ts#L615-L617

the method is supposed to accept a model class, but the actual implementation passes a string.

贡献者指南