VSCodeVim/Vim

Remove subclassing from actions.ts

开放

#519 创建于 2016年7月26日

 (0 条评论) (1 个反应) (0 位负责人)TypeScript (1,271 个派生)batch import
help wantedkind/refactorsize/M

仓库指标

星标
 (12,664 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

We have this pattern going on in actions.ts where, if we want to implement an action that's similar to another action, we make a new class that just extends the old class and reimplements what changed.

I am not a big fan of this. The main problem is that if someone changes the base class, it's not obvious at all that the subclasses could have been depending on the behavior of the base class.

I would like to refactor actions.ts so that no concrete actions extend from other concrete actions. This can be done in two steps.

  • For all actions that are synonyms (ctrl-[ and esc, for example), we need to make the keys variable accept a list of key sequences rather than just one.
  • For all actions that are not synonyms but actually have differing implementations (not sure how many of these we even have), I am ok with extending from a shared "abstract" base class.

贡献者指南