TheSpyder/rescript-webapi

Remove trailing _ from method and parameter names

开放

#29 创建于 2021年9月23日

 (0 条评论) (0 个反应) (0 位负责人)ReScript (38 个派生)github user discovery
good first issue

仓库指标

星标
 (159 个星标)
PR 合并指标
 (30 天内没有已合并 PR)

描述

In many cases, ReScript syntax is unambiguous enough that a trailing _ is no longer required in places it was for ReasonML and OCaml syntax. A codebase search for _: turns up quite a lot of them. Examples: https://github.com/tinymce/rescript-webapi/blob/ea9bd980f1b2b2d516e518f1f9c166feb1073f33/src/Webapi/Webapi__Blob.res#L10

https://github.com/tinymce/rescript-webapi/blob/253ba954381a78b57bad249ea83c1f5b6ab2b428/src/Webapi/Dom/Webapi__Dom__HtmlFormElement.res#L17

The compiler will signal when removing the underscore is not allowed, making this a mostly trivial change (but some tests would be nice)

贡献者指南