ThePhrozenKeep/D2MOO

Have a clean way to declare and reference packet tables

Open

#100 创建于 2023年1月23日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (48 fork)auto 404
enhancementgood first issue

仓库指标

Star
 (159 star)
PR 合并指标
 (PR 指标待抓取)

描述

In D2Net Client.cpp, the size of the packet sizes table (std::size(gServerPacketSizeTable)) is hardcoded (0xB4).

We should probably have a constant for this, or put the table in its own header since it should only be included in D2Net's Client.cpp and Server.cpp.

Originally posted by @Lectem in https://github.com/ThePhrozenKeep/D2MOO/pull/96#discussion_r1083280497

贡献者指南