Не полные списки совместимых в некоторых магических спеллах · TauCetiStation/TauCetiClassic#2016

(2 评论) (0 反应) (0 负责人)DM (153 star) (433 fork)batch import

BugGood First IssueOld issue

描述

https://github.com/TauCetiStation/TauCetiClassic/blob/fce27146b2457fabc0f2adcee5c210b5266d12aa/code/datums/spells/mind_transfer.dm#L14 https://github.com/TauCetiStation/TauCetiClassic/blob/8e08ac2e808db83af5c44b6e944085a49febb1a6/code/datums/spells/barnyardcurse.dm#L20

Ниже как правило точное сравнение target.type in compatible_mobs, соответственно всякие ксеносы отпадают. Возможно стоит проход по списку и проверку на istype делать.

Обратил внимание после #2009, спасибо Unforg1v3n

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

贡献者指南

技术栈: 无
领域: backend
议题类型: bug
难度: 3
预计时间: half day
活动状态: stale
清晰度: mostly clear
前置要求: 无
新手友好度: 20
研究方向: The issue reports that in two magic spell files (mind transfer.dm and barnyardcurse.dm), the compatibility list for targets uses exact type comparison with `in`, which excludes subtypes like xenomorphs. The suggested fix is to iterate over the list and use `istype` checks instead. See the linked files: code/datums/spells/mind transfer.dm line 14 and code/datums/spells/barnyardcurse.dm line 20. The issue references PR #2009 for context. No maintainer response or assignee exists.