TanStack/query

Errored queries caught by ErrorBoundary are not retried on mount

Open

#2,712 创建于 2021年9月23日

在 GitHub 查看
 (43 评论) (5 反应) (0 负责人)TypeScript (49,427 star) (3,817 fork)batch import
bughelp wantedpackage: react-query

描述

Describe the bug I'm using Suspense and ErrorBoundaries and I'm seeing unexpected behavior when queries are erroring. If a query errors I'm displaying an ErrorBoundary for that part of the UI. Now if I navigate to another page using react-router-dom and navigate back to the page, the ErrorBoundary is still there and the query is not retried. I know that normally you would have to reset the error boundary while you are on the same page to trigger a re-run of the failed queries, but in this case I would've assumed that the queries are retried when I visit the page again, i.e. the components are mounted again.

To Reproduce

  1. Visit the Code Sandbox
  2. Open the console
  3. Wait until the error occurs and the fallback of the ErrorBoundary is shown: "An error occured!" (You need to click off of react-error-overlay to see it)
  4. Press the "Hide" button to unmount the ErrorBoundary
  5. Press the "Show" button to render it again
  6. Query is not re-executed and the error is immediately shown again

Expected behavior The query is re-executed after the component mounts, i.e. honoring the retryOnMount setting.

Desktop (please complete the following information):

  • Version: 3.24.4

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
ReactReact QueryError Boundary
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Investigate the interplay between ErrorBoundary and QueryErrorResetBoundary in React Query. The bug report includes a CodeSandbox reproduction. Focus on the query cache's error state persistence when a component unmounts and remounts. Check the `useBaseQuery` hook and the `QueryObserver` to see if error state is cleared on re mount. Also review comments in the issue (e.g., #2712) for any maintainer insights or proposed solutions.