Supervisor/supervisor

Eventlistener protocol "len" header changed in Supervisor 4

Open

#1,243 创建于 2019年5月23日

在 GitHub 查看
 (33 评论) (0 反应) (0 负责人)Python (7,941 star) (1,233 fork)batch import
eventshelp wanted

描述

@plockaby wrote comments of issue #1235:

Migrating from version 3 to version 4, my event listeners read from supervisor over stdin using a byte stream and then did the conversion to utf8 and chose to "backslashreplace" undecodable utf8 data. When I went to version 4 I expected to continue to get a byte stream that I could convert myself to whatever encoding I knew the data to be in. It was really unexpected to discover that supervisor was doing the conversion for me and then telling me the number of characters to read off of stdin and not the number of bytes.

cc: @vsajip

贡献者指南

技术栈
python
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Knowledge of PythonUnderstanding of Supervisor event listener protocol
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the change in the 'len' header from bytes to characters in Supervisor's event listener protocol. Review the pull request discussion at PR #1235 and the referenced issue #1235. Look at the supervisor/events.py or similar files where stdin reading and header parsing occurs. Determine if the conversion to characters is intentional or a bug, and consider adding a configuration option to preserve byte based behavior.