StackStorm/st2

`st2 pack install` will ignore failures when installing multiple packs

Open

#4,620 创建于 2019年4月4日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Python (5,794 star) (740 fork)batch import
CLIbugcomplexity:easygood first issue

描述

SUMMARY

If I attempt to install multiple packs using st2 pack install, and one of those packs is non-existent, it will silently ignore the failure.

ISSUE TYPE
  • Bug Report
STACKSTORM VERSION

st2 3.0dev (d86747c), on Python 2.7.12

OS / ENVIRONMENT / INSTALL METHOD

one-line install.

STEPS TO REPRODUCE
extreme@ubuntu:~$ st2 pack install foobar acos

For the "foobar, acos" packs, the following content will be registered:

rules     |  0
sensors   |  0
aliases   |  0
actions   |  19
triggers  |  0

Installation may take a while for packs with many items.

	[ succeeded ] download pack
	[ succeeded ] make a prerun
	[ succeeded ] install pack dependencies
	[ succeeded ] register pack

+-------------+-----------------------------------------------+
| Property    | Value                                         |
+-------------+-----------------------------------------------+
| name        | acos                                          |
| description | Manage ACOS-based appliances of A10 Networks. |
| version     | 0.2.5                                         |
| author      | Hiroyasu OHYAMA                               |
+-------------+-----------------------------------------------+
extreme@ubuntu:~$
EXPECTED RESULTS

I expected some error message about "pack foobar not found", similar to if I had just tried st2 pack install foobar

ACTUAL RESULTS

Install completes 'successfully', since one pack install works.

贡献者指南

技术栈
pythonshell
领域
backendcli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of PythonFamiliarity with CLI toolsStackStorm pack installation flow
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the pack installation logic in the StackStorm codebase. Focus on the 'st2 pack install' command handler, likely in `st2actions/st2actions/pack install.py` or similar. The issue is that when installing multiple packs, failures from individual pack installations are not aggregated or reported. Look at how the command handles multiple pack names and how it reports success/failure. Consider modifying the code to return a non zero exit code and an error message when one or more packs fail.