StackGuardian/tirith

🐛 cli.py: return non zero code when final evaluation returns false

开放

#89 创建于 2022年11月28日

 (0 条评论) (0 个反应) (0 位负责人)Python (41 个派生)auto 404
buggood first issuehacktoberfest

仓库指标

星标
 (168 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Describe the bug tirith always return zero code even when the final evaluator returns false (failed)

To Reproduce I was using these files: plan.json.txt apigateway_state_logging_enabled.tirith.json.txt

Steps to reproduce the behavior:

  1. Download and rename both of the files above, from .txt to .json
  2. Run tirith -policy-path apigateway_state_logging_enabled.tirith.json -input-path plan.json
  3. The final evaluation should be failed
  4. Check the return code by doing echo $?
  5. It will print 0 instead of 1

Expected behavior It should return non-zero code as it will make the caller of the program knows that tirith final evaluation has failed

贡献者指南