Squirrel/Squirrel.Windows

VersionExtensions Regex does not support package ID ending with numbers

Open

#472 创建于 2015年10月27日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)C++ (1,061 fork)batch import
bug:failing-test-would-be-nicehelp wanted

仓库指标

Star
 (7,025 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Hi,

if you use NuGet Package Explorer and your nuget package id ends with a number updates won't work anymore (caused by changes in VersionExtensions.cs for prerelease support).

The NuGet Package Explorer uses a point to seperate the package id from the version number (at least if you don't change the filename).

ID: MyId123 Version: 1.1.0

The result would be "MyId123.1.1.0.nupkg"

The suffix regex will remove ".nupkg" and the version regex will match "123.1.1.0" instead of "1.1.0".

A workaround would be renaming your NuGet Package to "MyId123-1.1.0.nupkg". The code should be changed or this naming issue should be noted somewhere.

贡献者指南