SigNoz/signoz

Feat(FE): Global Time Visibility as per route

Open

#1,659 创建于 2022年10月25日

在 GitHub 查看
 (6 评论) (0 反应) (1 负责人)TypeScript (16,037 star) (976 fork)batch import
good first issuehacktoberfest

描述

Is your feature request related to a problem?

Please describe. Right now to show the global header we are using routesToSkip , need to refactor the logic to display according to the route where this component is required

eg:

routes = ['/services','/service/:id','/trace','/logs','/dashboard/:dashboardId','/exceptions','/service-map']

Describe the solution you'd like

we can keep an array of routes in which the header needs to disable

Thank you for your feature request – we love each and every one!

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
blocked
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactTypeScriptBasic routing concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
45
研究方向
Examine the current implementation in `frontend/src/container/TopNav/index.tsx` that uses `routesToSkip`. Identify the routes where the global header should be shown instead of hidden. Refactor by switching to a whitelist approach, and test the changes with the mentioned routes like `/services`, `/trace`, etc.