Semantic-Org/Semantic-UI-React

bug: [Popup] doesn't take into account popper's attributes, only styles

Open

#4,488 创建于 2024年7月24日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
buggood first issue

描述

Bug Report

state.attributes.popper aren't applied to the popup wrapper div, only state.styles.popper are.

Steps

  1. Use Popup component with default props and modifiers (which include hide by default) and on="click".
  2. Open the popup by clicking the trigger.
  3. Scroll the trigger out of the viewport.

Expected Result

The popup wrapper div gets the attributes data-popper-escaped and data-popper-reference-hidden from the default hide modifier.

Actual Result

No attributes are added to the div.

Version

2.1.5

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactPopper.js
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
75
研究方向
Look at the Popup component in Semantic UI React, likely in src/modules/Popup/Popup.js or similar. The popup wrapper div currently applies state.styles.popper but not state.attributes.popper. The fix involves merging attributes from state.attributes.popper into the wrapper div's props. Ensure that attributes like data popper escaped and data popper reference hidden from the hide modifier are passed to the div. Check the Popper.js documentation for how attributes are handled and verify that the default hide modifier is being used. The issue is isolated to the Popup component's rendering logic.