Semantic-Org/Semantic-UI-React

StrictTextAreaProps has a type that includes number and undefined for the "value" field

Open

#4,464 创建于 2024年2月20日

在 GitHub 查看
 (6 评论) (0 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
buggood first issue

描述

Bug Report

Steps

<Form.TextArea onChange={(_: unknown, data: TextAreaProps) => {
  const s: string =  data.value;
}}/>

Expected Result

No TypeScript errors.

Actual Result

Type 'string | number | undefined' is not assignable to type 'string'.

Version

2.1.5

Testcase

https://codesandbox.io/p/sandbox/semantic-ui-react-forked-5tf5yh

Notes

It doesn't appear to be possible to actually set the value of the textarea to a number or undefined, so it's not clear why I'd have to cast, and it's very inconvenient to cast undefined to a String since String(undefined) is "undefined" instead of "".

贡献者指南

技术栈
reacttypescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
TypeScript basicsReact components
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Look at the type definition for StrictTextAreaProps in the Form.TextArea component source. The issue is that 'value' is typed as string | number | undefined, but it should only be string. Find the type file (likely in src/components/Form/FormTextArea.d.ts) and update the type to be string. Ensure that changing this does not break other uses of the same prop in other components.