Semantic-Org/Semantic-UI-React

Dropdown doesn't close when placed inside of Checkbox component

Open

#4,036 创建于 2020年8月15日

在 GitHub 查看
 (7 评论) (0 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wanted

描述

Bug Report

Steps

  1. Click on dropdown
  2. Click on one of the options

Expected Result

The dropdown menu should close

Actual Result

It remains open until you click on one of the options one more time or click outside of the menu

Version

1.2.0

Testcase

https://codesandbox.io/s/vigorous-ives-l0qwm?file=/example.js

贡献者指南

技术栈
javascriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic React knowledgeUnderstanding of event propagation
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate event handling in Dropdown and Checkbox components. Look at https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Dropdown/Dropdown.js and https://github.com/Semantic Org/Semantic UI React/blob/master/src/modules/Checkbox/Checkbox.js to understand click propagation. The issue may be related to event.stopPropagation() interfering with dropdown close logic. Test the behavior in the provided CodeSandbox and identify where the click event is being swallowed.
Dropdown doesn't close when placed inside of Checkbox component · Semantic-Org/Semantic-UI-React#4036 | Good First Issue