Semantic-Org/Semantic-UI-React

Popup: Incorrect position of arrow

Open

#3,771 创建于 2019年9月2日

在 GitHub 查看
 (7 评论) (7 反应) (0 负责人)JavaScript (4,065 fork)batch import
bughelp wantedneeds engineering

仓库指标

Star
 (13,136 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

Bug Report

Steps

  1. Create an element with a popup
  2. Move that element to the right side of the page

Expected Result

I don't know an exact position of a trigger element on a page in advance but I expect popup and popup arrow will be displayed correctly everywhere as it was in 0.86.0. old

Actual Result

Popup arrow position is incorrect. The package doesn't calculate a popup position based on an actual popup trigger position. It passes down a position from props to popper and applies css styles based on that instead of calculating a correct value. In the previous version a position was changed to 'top right' but in current version it's 'top left' from defaultProps always. new

Version

0.88.0

Testcase

https://codesandbox.io/s/semantic-ui-react-o7mfd

贡献者指南