Semantic-Org/Semantic-UI-React

Popup: Incorrect position of arrow

Open

#3,771 创建于 2019年9月2日

在 GitHub 查看
 (7 评论) (7 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wantedneeds engineering

描述

Bug Report

Steps

  1. Create an element with a popup
  2. Move that element to the right side of the page

Expected Result

I don't know an exact position of a trigger element on a page in advance but I expect popup and popup arrow will be displayed correctly everywhere as it was in 0.86.0. old

Actual Result

Popup arrow position is incorrect. The package doesn't calculate a popup position based on an actual popup trigger position. It passes down a position from props to popper and applies css styles based on that instead of calculating a correct value. In the previous version a position was changed to 'top right' but in current version it's 'top left' from defaultProps always. new

Version

0.88.0

Testcase

https://codesandbox.io/s/semantic-ui-react-o7mfd

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React basicsCSS positioningPopup component knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
The bug is in the Popup component's positioning logic. The issue provides a CodeSandbox testcase (https://codesandbox.io/s/semantic ui react o7mfd). The maintainers need to investigate why the position prop is not being recalculated based on the trigger element's actual position, as it was in version 0.86.0. Likely related files are `src/modules/Popup` and the positioning utility.