Semantic-Org/Semantic-UI-React

Search: ability to pass Image props in SearchResult

开放

#3,619 创建于 2019年5月24日

 (4 条评论) (0 个反应) (0 位负责人)JavaScript (4,065 个派生)batch import
enhancementhelp wanted

仓库指标

星标
 (13,136 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Feature Request

Problem description

I wanted to use circular images in <Search> results. However, the image prop only accepts a string according to the documentation, not a props object.

I tried passing an object anyway { circular : true, src : 'https://...' } and it renders the image successfully. However, the image isn't circular, despite the fact that the circular class is correctly applied. The border-radius seems to be overridden by a selector with higher precedence. I then tried using a custom render function and had the same result.

Since the documentation doesn't indicate that props objects are supported here, maybe this is expected? But it's kind of surprising nonetheless.

Proposed solution

Officially support props object for image and fix any relevant CSS precedence issues.

MVP

https://codesandbox.io/s/semantic-ui-react-xce2z

贡献者指南