Semantic-Org/Semantic-UI-React

Rework TransitionablePortal callbacks for consistency

开放

#2,423 创建于 2018年1月10日

 (9 条评论) (0 个反应) (0 位负责人)JavaScript (4,065 个派生)batch import
bughelp wanted

仓库指标

星标
 (13,136 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Steps

  1. Create a controlled <TransitionablePortal />
  2. Toggle the open prop from false to true
  3. Trigger a close with ESC or click outside

Expected Result

  1. On prop change to open, the onOpen callback should not be called. This is a programmatic prop change, not a trigger click.
  2. When a close event is triggered, the onClose callback should be called before starting the transition as the user may choose to disregard the close request.

Actual Result

  1. On prop change to open, onOpen is called at the beginning and end of the open transition
  2. When a close event is triggered, the onClose callback is called after the onHide callback. There is no way to handle the close request and ignore it.

See the test case for proposed fixes.

Version

0.77.2

Testcase

https://codesandbox.io/s/rj8qv1yl2o

贡献者指南