Semantic-Org/Semantic-UI-React

Dropdown: incorrect focus

Open

#2,046 创建于 2017年9月4日

在 GitHub 查看
 (15 评论) (0 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
bughelp wanted

描述

This applies to use in Chrome.

Testcase https://react.semantic-ui.com/modules/dropdown#dropdown-example-open-on-focus

Steps to Reproduce

  1. Click on the down arrow (NOT on the text of the drop-down) of the second dropdown
  2. Click on the down arrow again
  3. Press 'shift + tab' to navigate to the first dropdown

Expected The first dropdown should now have the focus

Result The second dropdown retains the focus.

** FIX ** This is because when clicking on the down arrow, its the <i ../> element that obtains the focus.

Applying the style pointer-events: none; to the <i .../> element resolves the issue, when the down arrow is clicked focus is passed through to the dropdown component as expected.

贡献者指南

技术栈
javascriptreactcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
CSSReact
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
95
研究方向
The suggested fix is to add 'pointer events: none;' to the <i> icon element inside the Dropdown component. Locate the CSS file responsible for dropdown styles (likely in the 'src' directory of the Semantic UI React package). Apply the style and test in Chrome to ensure focus passes to the dropdown component when clicking the arrow.