Semantic-Org/Semantic-UI-React

Popup: triggers that do not spread props do not work

Open

#1,187 创建于 2017年1月19日

在 GitHub 查看
 (8 评论) (1 反应) (0 负责人)JavaScript (13,136 star) (4,065 fork)batch import
enhancementhelp wanted

描述

Steps

  1. Create a stateless component.
  2. Pass it to Popup as the trigger prop.

Expected Result

Get the popup when mousing over the trigger component.

Actual Result

Don't get a popup when mousing over the trigger component.

Version

0.64.2 (master)

Testcase

http://codepen.io/anon/pen/VPpZQL

贡献者指南

技术栈
reactjavascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
React basicsunderstanding of component props
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug occurs when a stateless component is passed as the `trigger` prop without spreading props. Investigate the Popup component's source code (likely in `src/modules/Popup`) to see how it renders the trigger. Check if there is a missing spread of props onto the trigger element. The provided CodePen testcase can be used to replicate. Look at how similar components handle prop spreading in this codebase.
Popup: triggers that do not spread props do not work · Semantic-Org/Semantic-UI-React#1187 | Good First Issue