SSENSE/vue-carousel

Feature request: Use style classes instead of inline styles

Open

#48 创建于 2017年4月19日

在 GitHub 查看
 (4 评论) (11 反应) (0 负责人)JavaScript (1,705 star) (513 fork)batch import
featurehelp wanted

描述

There're a few component options regarding styles such as paginationActiveColor, paginationPadding, etc. Since they are rendered as inline styles, it is hard to override them with CSS classes. It's better to set CSS classed for these elements. What do you think?

贡献者指南

技术栈
vuejavascript
领域
frontend
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic VueCSS knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the current implementation of the carousel component, likely in a .vue file. Identify all props like `paginationActiveColor`, `paginationPadding` that set inline styles. Propose a mapping to CSS classes and consider how to allow user overrides. Review any existing comments or linked issues for design preferences.