SFTtech/openage

Trigger reconfigure when git commit hash changes

Open

#381 创建于 2015年9月15日

在 GitHub 查看
 (3 评论) (0 反应) (0 负责人)Python (12,130 star) (1,135 fork)batch import
area: buildsystemgood first issueimprovementjust do it

描述

When the value of git describe changes, we should trigger a reconfigure when typing make. This ensures the version generated to config.h matches with the actual repository version.

The "dirty" solution would be checking for the version each time, something better would be a update watch on some file in ./.git/, but maybe you have a better idea how cmake may detect a changed HEAD efficiently.

贡献者指南

技术栈
ccpp
领域
build system
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Investigate the current CMake build system in openage, specifically how `git describe` is used to generate version information in `config.h`. Look for existing cmake functions that compute the version and where they are invoked. Then implement a dependency on `.git/HEAD` or a similar file to trigger reconfiguration when the commit hash changes. Consider using CMake's `configure file` with `CONFIGURE DEPENDS` or adding a custom target that depends on the git file. Review the comments on the issue for any alternative suggestions.