RipMeApp/ripme

Implement subdirectory sanitisation

Open

#16 创建于 2017年7月9日

在 GitHub 查看
 (10 评论) (0 反应) (0 负责人)Java (3,524 star) (640 fork)batch import
enhancementhelp wanted

描述

The addURLToDownload method in AbstractRipper should have sanitisation implemented for sub directories. It's currently possible to pass invalid characters and have the directory creation fail. This is particularly an issue on Windows platforms.

Another side effect of no sanitisation is that slashes in the directory name create further subdirectories.

贡献者指南

技术栈
java
领域
clidesktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Javafile I/Oregular expressions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the addURLToDownload method in AbstractRipper.java. Implement a sanitization function that removes or replaces invalid filesystem characters (e.g., <, >, :, ", /, \, |, ?, *) from subdirectory names. Consider using platform specific filename checks like File.separatorChar or a regex pattern. Look at any existing test files for ripper methods and consider adding a unit test for the sanitization logic. Check the issue comments for any proposed solutions or discussions.