PythonCharmers/python-future

urllib.parse.unquote may return bytes

Open

#431 创建于 2019年1月21日

在 GitHub 查看
 (1 评论) (0 反应) (1 负责人)Python (1,172 star) (327 fork)batch import
0.19help wanted

描述

In Py3, unquote does not accept bytes: the first line if '%' not in string would throw exception.

However, in Py2, that line will not throw exception and perform the checking.

When there's no %, the return value is the argument. That is, when the argument type is bytes, the return value is bytes, too.

Code snippet excerption from src/future/backports/urllib/parse.py#L515:

def unquote(string):
  if '%' not in string:
    string.split
    return string      # bytes or unicode, depends on argument; Py3 never reach here
  ...
  return ''.join(res)  # unicode

贡献者指南

技术栈
python
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic understanding of Python 2/3 string handlingFamiliarity with urllib.parse
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue is in src/future/backports/urllib/parse.py at line 515. The function unquote should return str in both Python 2 and 3. The fix should ensure that when input is bytes, it is decoded or converted to str before processing. Consider adding a check for bytes type and converting using .decode('utf 8') or similar. The current code returns bytes if no '%' is in string, which is inconsistent. Check the Python 3 implementation for reference.