PythonCharmers/python-future

newbytes is unable to handle a generator as a parameter

Open

#288 创建于 2017年6月21日

在 GitHub 查看
 (0 评论) (1 反应) (0 负责人)Python (1,172 star) (327 fork)batch import
0.20bughelp wanted

描述

After only checking that the parameter is Iterable, newbytes then checks the parameters len(). https://github.com/PythonCharmers/python-future/blob/39a066ed8c29a0b3a32adac2ffd407119fe9ea6d/src/future/types/newbytes.py#L106

https://repl.it/IwSF/2

print(repr(bytes.newbytes(x for x in range(0))))

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    print(repr(bytes.newbytes(x for x in range(0))))
  File "/home/runner/bytes.py", line 103, in __new__
    if len(args[0]) == 0:
TypeError: object of type 'generator' has no len()

Including a check for Sized as well avoids this.

if isinstance(args[0], Sized) and len(args[0]) == 0:

https://repl.it/IwSF/1

贡献者指南

技术栈
python
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python basicsUnderstanding of iterables
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
The bug is in `newbytes. new ` in `src/future/types/newbytes.py` around line 106. The code currently checks `len(args[0])` without confirming the argument supports `len()`. Generators are iterable but not sized, causing a `TypeError`. The fix is to add an `isinstance(args[0], Sized)` check before calling `len()`. You'll need to import `Sized` from `collections.abc` (or `collections` depending on Python version). Review the existing imports and modify the condition accordingly.