PythonCharmers/python-future

libfuturize.fixes.fix_absolute_import duplicates initial comments

Open

#281 创建于 2017年4月27日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)Python (1,172 star) (327 fork)batch import
0.19bughelp wanted

描述

precondition

  • Create thing/{__init__.py,foo.py,bar.py}
  • Fill foo.py with the following: 
    #!/usr/bin/env python
# -*- encoding: utf-8 -*-
import bar
  • run fix_absolute_import on thing

expected

foo.py should have become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
from . import bar

observed

foo.py has actually become:

#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from __future__ import absolute_import
#!/usr/bin/env python
# -*- encoding: utf-8 -*-
from . import bar

贡献者指南

技术栈
python
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python basicsUnderstanding of libfuturize
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The bug is in the `fix absolute import` fixer within `libfuturize.fixes`. The issue is that when processing a file with initial comments, the fixer duplicates those comments after inserting the `from future import absolute import` line. Look at the logic that handles the initial comment block and the insertion point for the future import. The expected behavior is to insert the future import without duplicating the comments. Investigate the relevant file (likely `libfuturize/fixes/fix absolute import.py`) and the method that inserts imports, possibly by checking if comments are being re added unnecessarily. The fix might involve ensuring that the comment block is only written once. The issue is clear from the provided example, and no maintainer input is required.